diff --git a/src/handlers/event/analyze_logs/issues.rs b/src/handlers/event/analyze_logs/issues.rs index 0f411e9..191e597 100644 --- a/src/handlers/event/analyze_logs/issues.rs +++ b/src/handlers/event/analyze_logs/issues.rs @@ -187,8 +187,8 @@ async fn outdated_launcher(log: &str, data: &Data) -> Result { let version_from_log = captures[0].replace("Prism Launcher version: ", ""); let storage = &data.storage; - let latest_version = if storage.launcher_version_is_cached().await? { - storage.get_launcher_version().await? + let latest_version = if let Ok(version) = storage.get_launcher_version().await { + version } else { let version = data .octocrab diff --git a/src/storage/mod.rs b/src/storage/mod.rs index 6bbed10..313aebc 100644 --- a/src/storage/mod.rs +++ b/src/storage/mod.rs @@ -60,6 +60,7 @@ impl Storage { Ok(exists > 0) } + /* we'll probably use this again async fn delete_key(&self, key: &str) -> Result<()> { debug!("Deleting key {key}"); @@ -68,6 +69,7 @@ impl Storage { Ok(()) } + */ async fn expire_key(&self, key: &str, expire_seconds: i64) -> Result<()> { debug!("Expiring key {key} in {expire_seconds}"); @@ -84,7 +86,7 @@ impl Storage { // Just store some value. We only care about the presence of this key self.set_key(&key, 0).await?; - self.expire_key(&key, 7 * 24 * 60 * 60).await?; + self.expire_key(&key, 7 * 24 * 60 * 60).await?; // weekly Ok(()) } @@ -96,6 +98,7 @@ impl Storage { pub async fn cache_launcher_version(&self, version: &str) -> Result<()> { self.set_key(LAUNCHER_VERSION_KEY, version).await?; + self.expire_key(LAUNCHER_VERSION_KEY, 24 * 60 * 60).await?; // 1 day Ok(()) } @@ -105,10 +108,4 @@ impl Storage { Ok(res) } - - pub async fn launcher_version_is_cached(&self) -> Result { - let res = self.key_exists(LAUNCHER_VERSION_KEY).await?; - - Ok(res) - } }