StarMC/Astral-nook
StarMC/Astral-nook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use a post request to delete SSH keys, some hashes use slashes which cause 404 errors; closes #4100

Browse source
This commit is contained in:
DaneEveritt 2022-05-30 17:28:42 -04:00
parent 5143faa4b1
commit 03a497fb8a
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53
5 changed files with 24 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

20
app/Http/Controllers/Api/Client/SSHKeyController.php
View file

@ -45,16 +45,22 @@ class SSHKeyController extends ClientApiController
/**
* Deletes an SSH key from the user's account.
*/
public function delete(ClientApiRequest $request, string $identifier): JsonResponse
public function delete(ClientApiRequest $request): JsonResponse
{
$key = $request->user()->sshKeys()->where('fingerprint', $identifier)->firstOrFail();
$this->validate($request, ['fingerprint' => ['required', 'string']]);
$key->delete();
$key = $request->user()->sshKeys()
->where('fingerprint', $request->input('fingerprint'))
->first();
Activity::event('user:ssh-key.delete')
->subject($key)
->property('fingerprint', $key->fingerprint)
->log();
if (!is_null($key)) {
$key->delete();
Activity::event('user:ssh-key.delete')
->subject($key)
->property('fingerprint', $key->fingerprint)
->log();
}
return new JsonResponse([], JsonResponse::HTTP_NO_CONTENT);
}