StarMC/Astral-nook
StarMC/Astral-nook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't allow editing read only values; closes #2252

Browse source
This commit is contained in:
Dane Everitt 2020-08-23 14:56:05 -07:00
parent 92929c45d5
commit 5173f1f7e8
No known key found for this signature in database
GPG key ID: EEA66103B3D71F53
2 changed files with 22 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/Http/Controllers/Api/Client/Servers/StartupController.php
View file

@ -55,9 +55,13 @@ class StartupController extends ClientApiController
/** @var \Pterodactyl\Models\EggVariable $variable */
$variable = $server->variables()->where('env_variable', $request->input('key'))->first();
if (is_null($variable) || !$variable->user_viewable || !$variable->user_editable) {
if (is_null($variable) || !$variable->user_viewable) {
throw new BadRequestHttpException(
"The environment variable you are trying to edit [\"{$request->input('key')}\"] does not exist."
"The environment variable you are trying to edit does not exist."
);
} else if (! $variable->user_editable) {
throw new BadRequestHttpException(
"The environment variable you are trying to edit is read-only."
);
}