Add test coverage for the SSH key endpoints

tests/Integration/Api/Client/ClientApiIntegrationTestCase.php

@@ -15,6 +15,7 @@ use Pterodactyl\Models\Location;
 use Pterodactyl\Models\Schedule;
 use Illuminate\Support\Collection;
 use Pterodactyl\Models\Allocation;
+use Pterodactyl\Models\UserSSHKey;
 use Pterodactyl\Models\DatabaseHost;
 use Pterodactyl\Tests\Integration\TestResponse;
 use Pterodactyl\Tests\Integration\IntegrationTestCase;
@@ -77,6 +78,9 @@ abstract class ClientApiIntegrationTestCase extends IntegrationTestCase
             case Backup::class:
                 $link = "/api/client/servers/{$model->server->uuid}/backups/{$model->uuid}";
                 break;
+            case UserSSHKey::class:
+                $link = "/api/client/account/ssh-keys/$model->fingerprint";
+                break;
             default:
                 throw new InvalidArgumentException(sprintf('Cannot create link for Model of type %s', class_basename($model)));
         }

tests/Integration/Api/Client/SSHKeyControllerTest.php

@@ -0,0 +1,138 @@
+<?php
+
+namespace Pterodactyl\Tests\Integration\Api\Client;
+
+use phpseclib3\Crypt\EC;
+use Pterodactyl\Models\User;
+use Pterodactyl\Models\UserSSHKey;
+
+class SSHKeyControllerTest extends ClientApiIntegrationTestCase
+{
+    /**
+     * Test that only the SSH keys for the authenticated user are returned.
+     */
+    public function testSSHKeysAreReturned()
+    {
+        $user = User::factory()->create();
+        $user2 = User::factory()->create();
+
+        $key = UserSSHKey::factory()->for($user)->create();
+        UserSSHKey::factory()->for($user2)->rsa()->create();
+
+        $this->actingAs($user);
+        $response = $this->getJson('/api/client/account/ssh-keys')
+            ->assertOk()
+            ->assertJsonPath('object', 'list')
+            ->assertJsonPath('data.0.object', UserSSHKey::RESOURCE_NAME);
+
+        $this->assertJsonTransformedWith($response->json('data.0.attributes'), $key);
+    }
+
+    /**
+     * Test that a user's SSH key can be deleted, and that passing the fingerprint
+     * of another user's SSH key won't delete that key.
+     */
+    public function testSSHKeyCanBeDeleted()
+    {
+        $user = User::factory()->create();
+        $user2 = User::factory()->create();
+
+        $key = UserSSHKey::factory()->for($user)->create();
+        $key2 = UserSSHKey::factory()->for($user2)->create();
+
+        $this->actingAs($user);
+        $this->deleteJson($this->link($key))->assertNoContent();
+
+        $this->assertSoftDeleted($key);
+        $this->assertNotSoftDeleted($key2);
+
+        $this->deleteJson($this->link($key))->assertNoContent();
+        $this->deleteJson($this->link($key2))->assertNoContent();
+
+        $this->assertNotSoftDeleted($key2);
+    }
+
+    public function testDSAKeyIsRejected()
+    {
+        $user = User::factory()->create();
+        $key = UserSSHKey::factory()->dsa()->make();
+
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => $key->public_key,
+        ])
+            ->assertUnprocessable()
+            ->assertJsonPath('errors.0.detail', 'DSA keys are not supported.');
+
+        $this->assertEquals(0, $user->sshKeys()->count());
+    }
+
+    public function testWeakRSAKeyIsRejected()
+    {
+        $user = User::factory()->create();
+        $key = UserSSHKey::factory()->rsa(true)->make();
+
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => $key->public_key,
+        ])
+            ->assertUnprocessable()
+            ->assertJsonPath('errors.0.detail', 'RSA keys must be at least 2048 bytes in length.');
+
+        $this->assertEquals(0, $user->sshKeys()->count());
+    }
+
+    public function testInvalidOrPrivateKeyIsRejected()
+    {
+        $user = User::factory()->create();
+
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => 'invalid',
+        ])
+            ->assertUnprocessable()
+            ->assertJsonPath('errors.0.detail', 'The public key provided is not valid.');
+
+        $this->assertEquals(0, $user->sshKeys()->count());
+
+        $key = EC::createKey('Ed25519');
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => $key->toString('PKCS8'),
+        ])
+            ->assertUnprocessable()
+            ->assertJsonPath('errors.0.detail', 'The public key provided is not valid.');
+    }
+
+    public function testPublicKeyCanBeStored()
+    {
+        $user = User::factory()->create();
+        $key = UserSSHKey::factory()->make();
+
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => $key->public_key,
+        ])
+            ->assertOk()
+            ->assertJsonPath('object', UserSSHKey::RESOURCE_NAME)
+            ->assertJsonPath('attributes.public_key', $key->public_key);
+
+        $this->assertCount(1, $user->sshKeys);
+        $this->assertEquals($key->public_key, $user->sshKeys[0]->public_key);
+    }
+
+    public function testPublicKeyThatAlreadyExistsCannotBeAddedASecondTime()
+    {
+        $user = User::factory()->create();
+        $key = UserSSHKey::factory()->for($user)->create();
+
+        $this->actingAs($user)->postJson('/api/client/account/ssh-keys', [
+            'name' => 'Name',
+            'public_key' => $key->public_key,
+        ])
+            ->assertUnprocessable()
+            ->assertJsonPath('errors.0.detail', 'The public key provided already exists on your account.');
+
+        $this->assertEquals(1, $user->sshKeys()->count());
+    }
+}