Update a batch of failing tests

2017-10-07 23:29:08 -05:00 · 2017-10-07 23:29:08 -05:00 · 787346525b
commit 787346525b
parent c19c423568
13 changed files with 218 additions and 195 deletions
--- a/tests/Unit/Services/Eggs/Variables/VariableCreationServiceTest.php
+++ b/tests/Unit/Services/Eggs/Variables/VariableCreationServiceTest.php
@ -0,0 +1,119 @@
+<?php
+/**
+ * Pterodactyl - Panel
+ * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
+ *
+ * This software is licensed under the terms of the MIT license.
+ * https://opensource.org/licenses/MIT
+ */
+
+namespace Tests\Unit\Services\Eggs\Variables;
+
+use Mockery as m;
+use Tests\TestCase;
+use Pterodactyl\Models\Egg;
+use Pterodactyl\Models\EggVariable;
+use Pterodactyl\Services\Eggs\Variables\VariableCreationService;
+use Pterodactyl\Contracts\Repository\EggVariableRepositoryInterface;
+
+class VariableCreationServiceTest extends TestCase
+{
+    /**
+     * @var \Pterodactyl\Contracts\Repository\EggVariableRepositoryInterface|\Mockery\Mock
+     */
+    protected $repository;
+
+    /**
+     * @var \Pterodactyl\Services\Eggs\Variables\VariableCreationService
+     */
+    protected $service;
+
+    /**
+     * Setup tests.
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->repository = m::mock(EggVariableRepositoryInterface::class);
+
+        $this->service = new VariableCreationService($this->repository);
+    }
+
+    /**
+     * Test basic functionality, data should be stored in the database.
+     */
+    public function testVariableIsCreatedAndStored()
+    {
+        $data = ['env_variable' => 'TEST_VAR_123'];
+        $this->repository->shouldReceive('create')->with([
+            'egg_id' => 1,
+            'user_viewable' => false,
+            'user_editable' => false,
+            'env_variable' => 'TEST_VAR_123',
+        ])->once()->andReturn(new EggVariable);
+
+        $this->assertInstanceOf(EggVariable::class, $this->service->handle(1, $data));
+    }
+
+    /**
+     * Test that the option key in the data array is properly parsed.
+     */
+    public function testOptionsPassedInArrayKeyAreParsedProperly()
+    {
+        $data = ['env_variable' => 'TEST_VAR_123', 'options' => ['user_viewable', 'user_editable']];
+        $this->repository->shouldReceive('create')->with([
+            'egg_id' => 1,
+            'user_viewable' => true,
+            'user_editable' => true,
+            'env_variable' => 'TEST_VAR_123',
+            'options' => ['user_viewable', 'user_editable'],
+        ])->once()->andReturn(new EggVariable);
+
+        $this->assertInstanceOf(EggVariable::class, $this->service->handle(1, $data));
+    }
+
+    /**
+     * Test that all of the reserved variables defined in the model trigger an exception.
+     *
+     * @dataProvider reservedNamesProvider
+     * @expectedException \Pterodactyl\Exceptions\Service\Egg\Variable\ReservedVariableNameException
+     */
+    public function testExceptionIsThrownIfEnvironmentVariableIsInListOfReservedNames(string $variable)
+    {
+        $this->service->handle(1, ['env_variable' => $variable]);
+    }
+
+    /**
+     * Test that the egg ID applied in the function takes higher priority than an
+     * ID passed into the handler.
+     */
+    public function testEggIdPassedInDataIsNotApplied()
+    {
+        $data = ['egg_id' => 123456, 'env_variable' => 'TEST_VAR_123'];
+        $this->repository->shouldReceive('create')->with([
+            'egg_id' => 1,
+            'user_viewable' => false,
+            'user_editable' => false,
+            'env_variable' => 'TEST_VAR_123',
+        ])->once()->andReturn(new EggVariable);
+
+        $this->assertInstanceOf(EggVariable::class, $this->service->handle(1, $data));
+    }
+
+    /**
+     * Provides the data to be used in the tests.
+     *
+     * @return array
+     */
+    public function reservedNamesProvider()
+    {
+        $data = [];
+        $exploded = explode(',', EggVariable::RESERVED_ENV_NAMES);
+        foreach ($exploded as $e) {
+            $data[] = [$e];
+        }
+
+        return $data;
+    }
+}