Merge branch 'develop' into enhancement/wings-improved-server-loading

app/Http/Controllers/Admin/Nodes/NodeViewController.php

@@ -148,8 +148,8 @@ class NodeViewController extends Controller
     public function servers(Request $request, Node $node)
     {
         $this->plainInject([
-            'node' => Collection::wrap($node->makeVisible('daemonSecret'))
-                ->only(['scheme', 'fqdn', 'daemonListen', 'daemonSecret']),
+            'node' => Collection::wrap($node->makeVisible(['daemon_token_id', 'daemon_token']))
+                ->only(['scheme', 'fqdn', 'daemonListen', 'daemon_token_id', 'daemon_token']),
         ]);
 
         return $this->view->make('admin.nodes.view.servers', [

app/Http/Controllers/Admin/StatisticsController.php

@@ -67,7 +67,7 @@ class StatisticsController extends Controller
 
         $tokens = [];
         foreach ($nodes as $node) {
-            $tokens[$node->id] = $node->daemonSecret;
+            $tokens[$node->id] = decrypt($node->daemon_token);
         }
 
         $this->injectJavascript([

app/Http/Controllers/Api/Remote/Servers/ServerTransferController.php

@@ -145,7 +145,7 @@ class ServerTransferController extends Controller
             ->canOnlyBeUsedAfter($now->getTimestamp())
             ->expiresAt($now->addMinutes(15)->getTimestamp())
             ->relatedTo($server->uuid, true)
-            ->getToken($signer, new Key($server->node->daemonSecret));
+            ->getToken($signer, new Key($server->node->getDecryptedKey()));
 
         // On the daemon transfer repository, make sure to set the node after the server
         // because setServer() tells the repository to use the server's node and not the one

app/Http/Controllers/Daemon/ActionController.php

@@ -1,107 +0,0 @@
-<?php
-
-namespace Pterodactyl\Http\Controllers\Daemon;
-
-use Cache;
-use Illuminate\Http\Request;
-use Pterodactyl\Models\Node;
-use Illuminate\Http\Response;
-use Illuminate\Http\JsonResponse;
-use Pterodactyl\Http\Controllers\Controller;
-use Pterodactyl\Repositories\Eloquent\ServerRepository;
-use Pterodactyl\Events\Server\Installed as ServerInstalled;
-use Illuminate\Contracts\Events\Dispatcher as EventDispatcher;
-use Pterodactyl\Exceptions\Repository\RecordNotFoundException;
-
-class ActionController extends Controller
-{
-    /**
-     * @var \Illuminate\Contracts\Events\Dispatcher
-     */
-    private $eventDispatcher;
-
-    /**
-     * @var \Pterodactyl\Repositories\Eloquent\ServerRepository
-     */
-    private $repository;
-
-    /**
-     * ActionController constructor.
-     *
-     * @param \Pterodactyl\Repositories\Eloquent\ServerRepository $repository
-     * @param \Illuminate\Contracts\Events\Dispatcher $eventDispatcher
-     */
-    public function __construct(ServerRepository $repository, EventDispatcher $eventDispatcher)
-    {
-        $this->eventDispatcher = $eventDispatcher;
-        $this->repository = $repository;
-    }
-
-    /**
-     * Handles install toggle request from daemon.
-     *
-     * @param \Illuminate\Http\Request $request
-     * @return \Illuminate\Http\JsonResponse
-     *
-     * @throws \Pterodactyl\Exceptions\Model\DataValidationException
-     * @throws \Pterodactyl\Exceptions\Repository\RecordNotFoundException
-     */
-    public function markInstall(Request $request): JsonResponse
-    {
-        try {
-            /** @var \Pterodactyl\Models\Server $server */
-            $server = $this->repository->findFirstWhere([
-                'uuid' => $request->input('server'),
-            ]);
-        } catch (RecordNotFoundException $exception) {
-            return JsonResponse::create([
-                'error' => 'No server by that ID was found on the system.',
-            ], Response::HTTP_UNPROCESSABLE_ENTITY);
-        }
-
-        if (! $server->relationLoaded('node')) {
-            $server->load('node');
-        }
-
-        $hmac = $request->input('signed');
-        $status = $request->input('installed');
-
-        if (! hash_equals(base64_decode($hmac), hash_hmac('sha256', $server->uuid, $server->getRelation('node')->daemonSecret, true))) {
-            return JsonResponse::create([
-                'error' => 'Signed HMAC was invalid.',
-            ], Response::HTTP_FORBIDDEN);
-        }
-
-        $this->repository->update($server->id, [
-            'installed' => ($status === 'installed') ? 1 : 2,
-        ], true, true);
-
-        // Only fire event if server installed successfully.
-        if ($status === 'installed') {
-            $this->eventDispatcher->dispatch(new ServerInstalled($server));
-        }
-
-        // Don't use a 204 here, the daemon is hard-checking for a 200 code.
-        return JsonResponse::create([]);
-    }
-
-    /**
-     * Handles configuration data request from daemon.
-     *
-     * @param \Illuminate\Http\Request $request
-     * @param string $token
-     * @return \Illuminate\Http\JsonResponse|\Illuminate\Http\Response
-     */
-    public function configuration(Request $request, $token)
-    {
-        $nodeId = Cache::pull('Node:Configuration:' . $token);
-        if (is_null($nodeId)) {
-            return response()->json(['error' => 'token_invalid'], 403);
-        }
-
-        $node = Node::findOrFail($nodeId);
-
-        // Manually as getConfigurationAsJson() returns it in correct format already
-        return $node->getJsonConfiguration();
-    }
-}

app/Http/Controllers/Daemon/PackController.php

@@ -1,73 +0,0 @@
-<?php
-/**
- * Pterodactyl - Panel
- * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
- *
- * This software is licensed under the terms of the MIT license.
- * https://opensource.org/licenses/MIT
- */
-
-namespace Pterodactyl\Http\Controllers\Daemon;
-
-use Storage;
-use Pterodactyl\Models;
-use Illuminate\Http\Request;
-use Pterodactyl\Http\Controllers\Controller;
-
-class PackController extends Controller
-{
-    /**
-     * Pulls an install pack archive from the system.
-     *
-     * @param \Illuminate\Http\Request $request
-     * @param string $uuid
-     * @return \Illuminate\Http\JsonResponse|\Symfony\Component\HttpFoundation\BinaryFileResponse
-     */
-    public function pull(Request $request, $uuid)
-    {
-        $pack = Models\Pack::where('uuid', $uuid)->first();
-
-        if (! $pack) {
-            return response()->json(['error' => 'No such pack.'], 404);
-        }
-
-        if (! Storage::exists('packs/' . $pack->uuid . '/archive.tar.gz')) {
-            return response()->json(['error' => 'There is no archive available for this pack.'], 503);
-        }
-
-        return response()->download(storage_path('app/packs/' . $pack->uuid . '/archive.tar.gz'));
-    }
-
-    /**
-     * Returns the hash information for a pack.
-     *
-     * @param \Illuminate\Http\Request $request
-     * @param string $uuid
-     * @return \Illuminate\Http\JsonResponse
-     */
-    public function hash(Request $request, $uuid)
-    {
-        $pack = Models\Pack::where('uuid', $uuid)->first();
-
-        if (! $pack) {
-            return response()->json(['error' => 'No such pack.'], 404);
-        }
-
-        if (! Storage::exists('packs/' . $pack->uuid . '/archive.tar.gz')) {
-            return response()->json(['error' => 'There is no archive available for this pack.'], 503);
-        }
-
-        return response()->json([
-            'archive.tar.gz' => sha1_file(storage_path('app/packs/' . $pack->uuid . '/archive.tar.gz')),
-        ]);
-    }
-
-    /**
-     * Pulls an update pack archive from the system.
-     *
-     * @param \Illuminate\Http\Request $request
-     */
-    public function pullUpdate(Request $request)
-    {
-    }
-}