Move location service to match other services

tests/Unit/Services/Locations/LocationCreationServiceTest.php

@@ -0,0 +1,71 @@
+<?php
+/*
+ * Pterodactyl - Panel
+ * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+namespace Tests\Unit\Services\Locations;
+
+use Mockery as m;
+use Tests\TestCase;
+use Pterodactyl\Models\Location;
+use Pterodactyl\Services\Locations\LocationCreationService;
+use Pterodactyl\Contracts\Repository\LocationRepositoryInterface;
+
+class LocationCreationServiceTest extends TestCase
+{
+    /**
+     * @var \Pterodactyl\Contracts\Repository\LocationRepositoryInterface
+     */
+    protected $repository;
+
+    /**
+     * @var \Pterodactyl\Services\Locations\LocationCreationService
+     */
+    protected $service;
+
+    /**
+     * Setup tests.
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->repository = m::mock(LocationRepositoryInterface::class);
+
+        $this->service = new LocationCreationService($this->repository);
+    }
+
+    /**
+     * Test that a location is created.
+     */
+    public function testLocationIsCreated()
+    {
+        $location = factory(Location::class)->make();
+
+        $this->repository->shouldReceive('create')->with(['test_data' => 'test_value'])->once()->andReturn($location);
+
+        $response = $this->service->handle(['test_data' => 'test_value']);
+        $this->assertNotEmpty($response);
+        $this->assertInstanceOf(Location::class, $response);
+        $this->assertEquals($location, $response);
+    }
+}

tests/Unit/Services/Locations/LocationDeletionServiceTest.php

@@ -1,5 +1,5 @@
 <?php
-/**
+/*
  * Pterodactyl - Panel
  * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
  *
@@ -22,22 +22,30 @@
  * SOFTWARE.
  */
 
-namespace Tests\Unit\Services;
+namespace Tests\Unit\Services\Locations;
 
 use Mockery as m;
 use Tests\TestCase;
-use Pterodactyl\Services\LocationService;
+use Pterodactyl\Exceptions\DisplayException;
+use Pterodactyl\Services\Locations\LocationDeletionService;
+use Pterodactyl\Contracts\Repository\NodeRepositoryInterface;
 use Pterodactyl\Contracts\Repository\LocationRepositoryInterface;
+use Pterodactyl\Exceptions\Service\Location\HasActiveNodesException;
 
-class LocationServiceTest extends TestCase
+class LocationDeletionServiceTest extends TestCase
 {
+    /**
+     * @var \Pterodactyl\Contracts\Repository\NodeRepositoryInterface
+     */
+    protected $nodeRepository;
+
     /**
      * @var \Pterodactyl\Contracts\Repository\LocationRepositoryInterface
      */
     protected $repository;
 
     /**
-     * @var \Pterodactyl\Services\LocationService
+     * @var \Pterodactyl\Services\Locations\LocationDeletionService
      */
     protected $service;
 
@@ -48,54 +56,36 @@ class LocationServiceTest extends TestCase
     {
         parent::setUp();
 
+        $this->nodeRepository = m::mock(NodeRepositoryInterface::class);
         $this->repository = m::mock(LocationRepositoryInterface::class);
 
-        $this->service = new LocationService($this->repository);
+        $this->service = new LocationDeletionService($this->repository, $this->nodeRepository);
     }
 
     /**
-     * Test that creating a location returns the correct information.
+     * Test that a location is deleted.
      */
-    public function test_create_location()
+    public function testLocationIsDeleted()
     {
-        $data = ['short' => 'shortCode', 'long' => 'longCode'];
+        $this->nodeRepository->shouldReceive('findCountWhere')->with([['location_id', '=', 123]])->once()->andReturn(0);
+        $this->repository->shouldReceive('delete')->with(123)->once()->andReturn(1);
 
-        $this->repository->shouldReceive('create')->with($data)->once()->andReturn((object) $data);
-
-        $response = $this->service->create($data);
-
-        $this->assertNotNull($response);
-        $this->assertObjectHasAttribute('short', $response);
-        $this->assertObjectHasAttribute('long', $response);
-        $this->assertEquals('shortCode', $response->short);
-        $this->assertEquals('longCode', $response->long);
+        $response = $this->service->handle(123);
+        $this->assertEquals(1, $response);
     }
 
     /**
-     * Test that updating a location updates it correctly.
+     * Test that an exception is thrown if nodes are attached to a location.
      */
-    public function test_update_location()
+    public function testExceptionIsThrownIfNodesAreAttached()
     {
-        $data = ['short' => 'newShort'];
+        $this->nodeRepository->shouldReceive('findCountWhere')->with([['location_id', '=', 123]])->once()->andReturn(1);
 
-        $this->repository->shouldReceive('update')->with(1, $data)->once()->andReturn((object) $data);
-
-        $response = $this->service->update(1, $data);
-
-        $this->assertNotNull($response);
-        $this->assertObjectHasAttribute('short', $response);
-        $this->assertEquals('newShort', $response->short);
-    }
-
-    /**
-     * Test that a location deletion returns valid data.
-     */
-    public function test_delete_location()
-    {
-        $this->repository->shouldReceive('deleteIfNoNodes')->with(1)->once()->andReturn(true);
-
-        $response = $this->service->delete(1);
-
-        $this->assertTrue($response);
+        try {
+            $this->service->handle(123);
+        } catch (DisplayException $exception) {
+            $this->assertInstanceOf(HasActiveNodesException::class, $exception);
+            $this->assertEquals(trans('exceptions.locations.has_nodes'), $exception->getMessage());
+        }
     }
 }

tests/Unit/Services/Locations/LocationUpdateServiceTest.php

@@ -0,0 +1,82 @@
+<?php
+/*
+ * Pterodactyl - Panel
+ * Copyright (c) 2015 - 2017 Dane Everitt <dane@daneeveritt.com>.
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a copy
+ * of this software and associated documentation files (the "Software"), to deal
+ * in the Software without restriction, including without limitation the rights
+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+ * copies of the Software, and to permit persons to whom the Software is
+ * furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice shall be included in all
+ * copies or substantial portions of the Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+ * SOFTWARE.
+ */
+
+namespace Tests\Unit\Services\Locations;
+
+use Mockery as m;
+use Tests\TestCase;
+use Pterodactyl\Models\Location;
+use Pterodactyl\Services\Locations\LocationUpdateService;
+use Pterodactyl\Contracts\Repository\LocationRepositoryInterface;
+
+class LocationUpdateServiceTest extends TestCase
+{
+    /**
+     * @var \Pterodactyl\Contracts\Repository\LocationRepositoryInterface
+     */
+    protected $repository;
+
+    /**
+     * @var \Pterodactyl\Services\Locations\LocationUpdateService
+     */
+    protected $service;
+
+    /**
+     * Setup tests.
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->repository = m::mock(LocationRepositoryInterface::class);
+
+        $this->service = new LocationUpdateService($this->repository);
+    }
+
+    /**
+     * Test location is updated.
+     */
+    public function testLocationIsUpdated()
+    {
+        $model = factory(Location::class)->make(['id' => 123]);
+        $this->repository->shouldReceive('update')->with(123, ['test_data' => 'test_value'])->once()->andReturn($model);
+
+        $response = $this->service->handle($model->id, ['test_data' => 'test_value']);
+        $this->assertNotEmpty($response);
+        $this->assertInstanceOf(Location::class, $response);
+    }
+
+    /**
+     * Test that a model can be passed in place of an ID.
+     */
+    public function testModelCanBePassedToFunction()
+    {
+        $model = factory(Location::class)->make(['id' => 123]);
+        $this->repository->shouldReceive('update')->with(123, ['test_data' => 'test_value'])->once()->andReturn($model);
+
+        $response = $this->service->handle($model, ['test_data' => 'test_value']);
+        $this->assertNotEmpty($response);
+        $this->assertInstanceOf(Location::class, $response);
+    }
+}