Upgrade to Laravel 9 (#4413)

Co-authored-by: DaneEveritt <dane@daneeveritt.com>

tests/Unit/Helpers/IsDigitTest.php

@@ -18,10 +18,8 @@ class IsDigitTest extends TestCase
 
     /**
      * Provide data to test against the helper function.
-     *
-     * @return array
      */
-    public function helperDataProvider()
+    public function helperDataProvider(): array
     {
         return [
             [true, false],

tests/Unit/Http/Middleware/Api/Application/AuthenticateUserTest.php

@@ -21,7 +21,7 @@ class AuthenticateUserTest extends MiddlewareTestCase
     }
 
     /**
-     * Test that a non-admin user results an an exception.
+     * Test that a non-admin user results in an exception.
      */
     public function testNonAdminUser()
     {

tests/Unit/Http/Middleware/Api/Daemon/DaemonAuthenticateTest.php

@@ -3,6 +3,7 @@
 namespace Pterodactyl\Tests\Unit\Http\Middleware\Api\Daemon;
 
 use Mockery as m;
+use Mockery\MockInterface;
 use Pterodactyl\Models\Node;
 use Illuminate\Contracts\Encryption\Encrypter;
 use Pterodactyl\Repositories\Eloquent\NodeRepository;
@@ -15,15 +16,9 @@ use Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException;
 
 class DaemonAuthenticateTest extends MiddlewareTestCase
 {
-    /**
-     * @var \Mockery\MockInterface
-     */
-    private $repository;
+    private MockInterface $encrypter;
 
-    /**
-     * @var \Mockery\MockInterface
-     */
-    private $encrypter;
+    private MockInterface $repository;
 
     /**
      * Setup tests.

tests/Unit/Http/Middleware/LanguageMiddlewareTest.php

@@ -3,16 +3,14 @@
 namespace Pterodactyl\Tests\Unit\Http\Middleware;
 
 use Mockery as m;
+use Mockery\MockInterface;
 use Pterodactyl\Models\User;
 use Illuminate\Foundation\Application;
 use Pterodactyl\Http\Middleware\LanguageMiddleware;
 
 class LanguageMiddlewareTest extends MiddlewareTestCase
 {
-    /**
-     * @var \Illuminate\Foundation\Application|\Mockery\Mock
-     */
-    private $appMock;
+    private MockInterface $appMock;
 
     /**
      * Setup tests.

tests/Unit/Http/Middleware/MaintenanceMiddlewareTest.php

@@ -3,6 +3,7 @@
 namespace Pterodactyl\Tests\Unit\Http\Middleware;
 
 use Mockery as m;
+use Mockery\MockInterface;
 use Pterodactyl\Models\Node;
 use Illuminate\Http\Response;
 use Pterodactyl\Models\Server;
@@ -11,10 +12,7 @@ use Pterodactyl\Http\Middleware\MaintenanceMiddleware;
 
 class MaintenanceMiddlewareTest extends MiddlewareTestCase
 {
-    /**
-     * @var \Illuminate\Contracts\Routing\ResponseFactory|\Mockery\Mock
-     */
-    private $response;
+    private MockInterface $response;
 
     /**
      * Setup tests.

tests/Unit/Http/Middleware/RedirectIfAuthenticatedTest.php

@@ -3,16 +3,14 @@
 namespace Pterodactyl\Tests\Unit\Http\Middleware;
 
 use Mockery as m;
+use Mockery\MockInterface;
 use Illuminate\Auth\AuthManager;
 use Illuminate\Http\RedirectResponse;
 use Pterodactyl\Http\Middleware\RedirectIfAuthenticated;
 
 class RedirectIfAuthenticatedTest extends MiddlewareTestCase
 {
-    /**
-     * @var \Illuminate\Auth\AuthManager|\Mockery\Mock
-     */
-    private $authManager;
+    private MockInterface $authManager;
 
     /**
      * Setup tests.