fix(storage): set expiry for launcher version key
This commit is contained in:
parent
7252ced3cb
commit
2acb319821
2 changed files with 6 additions and 9 deletions
|
@ -187,8 +187,8 @@ async fn outdated_launcher(log: &str, data: &Data) -> Result<Issue> {
|
||||||
let version_from_log = captures[0].replace("Prism Launcher version: ", "");
|
let version_from_log = captures[0].replace("Prism Launcher version: ", "");
|
||||||
|
|
||||||
let storage = &data.storage;
|
let storage = &data.storage;
|
||||||
let latest_version = if storage.launcher_version_is_cached().await? {
|
let latest_version = if let Ok(version) = storage.get_launcher_version().await {
|
||||||
storage.get_launcher_version().await?
|
version
|
||||||
} else {
|
} else {
|
||||||
let version = data
|
let version = data
|
||||||
.octocrab
|
.octocrab
|
||||||
|
|
|
@ -60,6 +60,7 @@ impl Storage {
|
||||||
Ok(exists > 0)
|
Ok(exists > 0)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
/* we'll probably use this again
|
||||||
async fn delete_key(&self, key: &str) -> Result<()> {
|
async fn delete_key(&self, key: &str) -> Result<()> {
|
||||||
debug!("Deleting key {key}");
|
debug!("Deleting key {key}");
|
||||||
|
|
||||||
|
@ -68,6 +69,7 @@ impl Storage {
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
*/
|
||||||
|
|
||||||
async fn expire_key(&self, key: &str, expire_seconds: i64) -> Result<()> {
|
async fn expire_key(&self, key: &str, expire_seconds: i64) -> Result<()> {
|
||||||
debug!("Expiring key {key} in {expire_seconds}");
|
debug!("Expiring key {key} in {expire_seconds}");
|
||||||
|
@ -84,7 +86,7 @@ impl Storage {
|
||||||
|
|
||||||
// Just store some value. We only care about the presence of this key
|
// Just store some value. We only care about the presence of this key
|
||||||
self.set_key(&key, 0).await?;
|
self.set_key(&key, 0).await?;
|
||||||
self.expire_key(&key, 7 * 24 * 60 * 60).await?;
|
self.expire_key(&key, 7 * 24 * 60 * 60).await?; // weekly
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
@ -96,6 +98,7 @@ impl Storage {
|
||||||
|
|
||||||
pub async fn cache_launcher_version(&self, version: &str) -> Result<()> {
|
pub async fn cache_launcher_version(&self, version: &str) -> Result<()> {
|
||||||
self.set_key(LAUNCHER_VERSION_KEY, version).await?;
|
self.set_key(LAUNCHER_VERSION_KEY, version).await?;
|
||||||
|
self.expire_key(LAUNCHER_VERSION_KEY, 24 * 60 * 60).await?; // 1 day
|
||||||
|
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
@ -105,10 +108,4 @@ impl Storage {
|
||||||
|
|
||||||
Ok(res)
|
Ok(res)
|
||||||
}
|
}
|
||||||
|
|
||||||
pub async fn launcher_version_is_cached(&self) -> Result<bool> {
|
|
||||||
let res = self.key_exists(LAUNCHER_VERSION_KEY).await?;
|
|
||||||
|
|
||||||
Ok(res)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Add a link
Reference in a new issue